third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test expectations and compile error Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/notification_event_dispatcher.h ('K') | « third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.h ('k') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

diff --git a/third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl b/third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

index 2c57ffa754173ea8942160ede237350b971d8d13..45f2c54b541f486c68fadc3411c8623bb18d651f 100644

--- a/third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

+++ b/third_party/WebKit/Source/modules/notifications/ServiceWorkerGlobalScopeNotifications.idl

@@ -8,4 +8,5 @@

RuntimeEnabled=Notifications,

] partial interface ServiceWorkerGlobalScope {

attribute EventHandler onnotificationclick;

+ attribute EventHandler onnotificationclose;

};