content/common/service_worker/service_worker_messages.h - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test expectations and compile error Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 959b3f163a90712a91ebadf907f2f48317c7e39e..e59a893d6c79e6a623ca94c54b324563a9a41280 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -244,6 +244,9 @@ IPC_MESSAGE_ROUTED3(ServiceWorkerHostMsg_FetchEventFinished,

IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_NotificationClickEventFinished,

int /* request_id */,

blink::WebServiceWorkerEventResult)

+IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_NotificationCloseEventFinished,

+ int /* request_id */,

+ blink::WebServiceWorkerEventResult)

IPC_MESSAGE_ROUTED2(ServiceWorkerHostMsg_PushEventFinished,

int /* request_id */,

blink::WebServiceWorkerEventResult)

@@ -449,6 +452,10 @@ IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_NotificationClickEvent,

int64_t /* persistent_notification_id */,

content::PlatformNotificationData /* notification_data */,

int /* action_index */)

+IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_NotificationCloseEvent,

+ int /* request_id */,

+ int64_t /* persistent_notification_id */,

+ content::PlatformNotificationData /* notification_data */)

IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_PushEvent,

int /* request_id */,

content::PushEventPayload /* data */)