tools/metrics/histograms/histograms.xml - Issue 1619703002: Implement notificationclose event

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Trivial rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('K') | « third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index d1a640ee5ba531c3c47fca61dd8507b277f12a7d..6baa00e37c8b1ff72645e639a607ce8effaa0d59 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -30891,6 +30891,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

enum="BooleanSuccess">

<owner>peter@chromium.org</owner>

<owner>deepak.m1@samsung.com</owner>

+ <obsolete>

+ Deprecated 01/2016, no longer used.

+ </obsolete>

Recorded when the data associated with a persistent Web Notification gets

deleted. The value will be true if data deletion succeeded, and false if

@@ -30908,6 +30911,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Notifications.PersistentWebNotificationCloseResult"

+ enum="PlatformNotificationStatus">

+ <owner>peter@chromium.org</owner>

+ <owner>deepak.m1@samsumg.com</owner>

Peter Beverloo 2016/01/28 16:14:23 s/deepak/you/

Nina 2016/02/01 17:59:06 Done.

+ <summary>

+ Recorded delivery status for persistent notification close events to a

Peter Beverloo 2016/01/28 16:14:23 s/Recorded/Records/

Nina 2016/02/01 17:59:06 I rewrote the summary as it didn't sound right eve

+ Service Worker when handling a click on a persistent WebNotification has

Peter Beverloo 2016/01/28 16:14:23 WebNotification -> Web Notification

Nina 2016/02/01 17:59:06 ditto

+ finished.

+ </summary>

+</histogram>

<owner>bengr@chromium.org</owner>

<owner>tbansal@chromium.org</owner>

@@ -44209,6 +44223,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="ServiceWorker.NotificationCloseEvent.Time" units="ms">

+ <owner>nsatragno@chromium.org</owner>

+ <owner>peter@chromium.org</owner>

+ <summary>

+ The time taken between dispatching a NotificationCloseEvent to a Service

Peter Beverloo 2016/01/28 16:14:23 notificationcloseevent (no capitals)

Nina 2016/02/01 17:59:06 Done.

+ Worker and receiving a message that it finished handling the event. Includes

+ the time for the waitUntil() promise to settle.

+ </summary>

+</histogram>

<owner>falken@chromium.org</owner>

<summary>Counts page loads controlled by a service worker.</summary>