Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1619643004: PPC: [for-in] Sanitize for-in optimizations and fix bailout points. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [for-in] Sanitize for-in optimizations and fix bailout points. Port f48bf12f5ea99a9d01d390c0c7f51dc85a87f1cd Original commit message: The PrepareId bailout location was used incorrectly in Crankshaft and, as it turns out, is not required anyway (once you do it right). Also there was some premature optimization going on with the CheckEnumCache (trying to load null from roots only once), plus we can be smarter about the null/undefined check anyway. The idea behind this changes is to prepare unification of the two different ForInPrepare implementations that we now have, with the end result being that we only use the new implementation that was recently added for the interpreter. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:3650 LOG=n Committed: https://crrev.com/cbc0564037991a69975edb0e3fdc33df9cf472c0 Cr-Commit-Position: refs/heads/master@{#33447}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -38 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +1 line, -15 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +11 lines, -18 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-21 17:55:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619643004/1
4 years, 11 months ago (2016-01-21 17:56:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 18:18:26 UTC) #5
john.yan
lgtm
4 years, 11 months ago (2016-01-21 19:07:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619643004/1
4 years, 11 months ago (2016-01-21 19:12:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10026)
4 years, 11 months ago (2016-01-21 19:14:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619643004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619643004/20001
4 years, 11 months ago (2016-01-21 19:20:57 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 19:45:59 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:46:29 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbc0564037991a69975edb0e3fdc33df9cf472c0
Cr-Commit-Position: refs/heads/master@{#33447}

Powered by Google App Engine
This is Rietveld 408576698