Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1619623005: Avoid updating glPathStencilFunc unless it changes (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid updating glPathStencilFunc unless it changes Avoid updating glPathStencilFunc unless it changes. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619623005 Committed: https://skia.googlesource.com/skia/+/1517f93439bb974d871098cff632627e13524620

Patch Set 1 #

Total comments: 2

Patch Set 2 : eh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/gpu/GrStencil.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Kimmo Kinnunen
small thing
4 years, 11 months ago (2016-01-22 14:02:31 UTC) #3
bsalomon
https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h File src/gpu/GrStencil.h (right): https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h#newcode283 src/gpu/GrStencil.h:283: bool isValid() const { as implemented, shouldn't this be ...
4 years, 11 months ago (2016-01-22 14:38:38 UTC) #4
Kimmo Kinnunen
https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h File src/gpu/GrStencil.h (right): https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h#newcode283 src/gpu/GrStencil.h:283: bool isValid() const { On 2016/01/22 14:38:38, bsalomon wrote: ...
4 years, 11 months ago (2016-01-25 08:33:13 UTC) #5
bsalomon
On 2016/01/25 08:33:13, Kimmo Kinnunen wrote: > https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h > File src/gpu/GrStencil.h (right): > > https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h#newcode283 ...
4 years, 11 months ago (2016-01-25 13:53:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619623005/20001
4 years, 11 months ago (2016-01-25 13:56:24 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 14:07:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1517f93439bb974d871098cff632627e13524620

Powered by Google App Engine
This is Rietveld 408576698