Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1619623005

Committed: https://skia.googlesource.com/skia/+/1517f93439bb974d871098cff632627e13524620

[Kimmo Kinnunen, 2016-01-22 14:01:41]

Description was changed from

==========
Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes.
==========

to

==========
Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-01-22 14:02:31]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[Kimmo Kinnunen, 2016-01-22 14:02:31]

small thing

[bsalomon, 2016-01-22 14:38:38]

https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h
File src/gpu/GrStencil.h (right):

https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h#newcode283
src/gpu/GrStencil.h:283: bool isValid() const {
as implemented, shouldn't this be called isInvalid()?

Other than that this lgtm.

[Kimmo Kinnunen, 2016-01-25 08:33:13]

https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h
File src/gpu/GrStencil.h (right):

https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h#newcode283
src/gpu/GrStencil.h:283: bool isValid() const {
On 2016/01/22 14:38:38, bsalomon wrote:
> as implemented, shouldn't this be called isInvalid()?
> 
> Other than that this lgtm.

Ah, where is my head at.. I fixed this and changed the style sligthly, is it
still ok?

[bsalomon, 2016-01-25 13:53:40]

On 2016/01/25 08:33:13, Kimmo Kinnunen wrote:
> https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h
> File src/gpu/GrStencil.h (right):
> 
>
https://codereview.chromium.org/1619623005/diff/1/src/gpu/GrStencil.h#newcode283
> src/gpu/GrStencil.h:283: bool isValid() const {
> On 2016/01/22 14:38:38, bsalomon wrote:
> > as implemented, shouldn't this be called isInvalid()?
> > 
> > Other than that this lgtm.
> 
> Ah, where is my head at.. I fixed this and changed the style sligthly, is it
> still ok?

lgtm

[Kimmo Kinnunen, 2016-01-25 13:56:13]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-01-25 13:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619623005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619623005/20001

[commit-bot: I haz the power, 2016-01-25 14:07:28]

Description was changed from

==========
Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Avoid updating glPathStencilFunc unless it changes

Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1517f93439bb974d871098cff632627e13524620
==========

[commit-bot: I haz the power, 2016-01-25 14:07:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1517f93439bb974d871098cff632627e13524620