sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart - Issue 16196012: Revert r23577, some unit tests fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

Issue 16196012: Revert r23577, some unit tests fail. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (revision 23577)

+++ sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (working copy)

@@ -27,7 +27,6 @@

HType candidateType = HType.CONFLICTING;

for (int i = 0, length = phi.inputs.length; i < length; i++) {

HType inputType = phi.inputs[i].instructionType;

- if (inputType.isConflicting()) return HType.CONFLICTING;

if (ignoreUnknowns && inputType.isUnknown()) continue;

// Phis need to combine the incoming types using the union operation.

// For example, if one incoming edge has type integer and the other has

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »