Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3012)

Unified Diff: build/android/gyp/apkbuilder.py

Issue 1619553003: Support uncompress and page align shared libraries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/finalize_apk.py » ('j') | build/android/gyp/finalize_apk.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/apkbuilder.py
diff --git a/build/android/gyp/apkbuilder.py b/build/android/gyp/apkbuilder.py
index 8c7a449fbb20b767401e95c5fb69a754294f0df0..2993e322eab1ce2273981b13219c7a3474e374c5 100755
--- a/build/android/gyp/apkbuilder.py
+++ b/build/android/gyp/apkbuilder.py
@@ -57,6 +57,9 @@ def _ParseArgs(args):
default='[]')
parser.add_argument('--emma-device-jar',
help='Path to emma_device.jar to include.')
+ parser.add_argument('--uncompress-shared-libraries',
+ action='store_true',
+ help='Uncompress shared libraries')
options = parser.parse_args(args)
options.assets = build_utils.ParseGypList(options.assets)
options.uncompressed_assets = build_utils.ParseGypList(
@@ -210,7 +213,14 @@ def main(args):
for path in native_libs:
basename = os.path.basename(path)
apk_path = 'lib/%s/%s' % (options.android_abi, basename)
- build_utils.AddToZipHermetic(out_apk, apk_path, src_path=path)
+
+ compress = not (options.uncompress_shared_libraries and
Yaron 2016/01/21 20:22:46 I'm not sure this is exactly right. This is forcin
michaelbai 2016/01/21 21:58:03 Thanks, I should keep previous behavior.
+ os.path.splitext(basename)[1] == '.so')
+
+ build_utils.AddToZipHermetic(out_apk,
+ apk_path,
+ src_path=path,
+ compress=compress)
for name in sorted(options.native_lib_placeholders):
# Empty libs files are ignored by md5check, but rezip requires them
« no previous file with comments | « no previous file | build/android/gyp/finalize_apk.py » ('j') | build/android/gyp/finalize_apk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698