Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16195004: add asserts to point<-->verb helpers (Closed)

Created:
7 years, 6 months ago by reed1
Modified:
7 years, 6 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add asserts to point<-->verb helpers patch from issue 16153005 BUG= Committed: https://code.google.com/p/skia/source/detail?r=9344

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+666 lines, -150 lines) Patch
M include/config/SkUserConfig.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkGeometry.h View 1 chunk +9 lines, -0 lines 0 comments Download
M include/core/SkPath.h View 1 2 7 chunks +23 lines, -3 lines 0 comments Download
M src/core/SkEdgeBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkEdgeBuilder.cpp View 3 chunks +46 lines, -5 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 36 chunks +124 lines, -38 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPathRef.h View 1 2 15 chunks +45 lines, -43 lines 0 comments Download
M src/core/SkRegion_path.cpp View 1 2 3 2 chunks +14 lines, -3 lines 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M src/pathops/SkOpSegment.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 17 chunks +19 lines, -19 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 2 3 4 2 chunks +44 lines, -0 lines 0 comments Download
M src/pathops/SkReduceOrder.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/utils/SkParsePath.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 2 3 4 5 3 chunks +103 lines, -7 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 2 chunks +168 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathTest.cpp View 1 2 3 4 5 6 5 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years, 6 months ago (2013-05-29 13:09:02 UTC) #1
reed1
need help on pathops assert when cycling through gms
7 years, 6 months ago (2013-05-29 14:54:24 UTC) #2
reed1
7 years, 6 months ago (2013-05-30 14:58:08 UTC) #3
Message was sent while issue was closed. 
Committed patchset #7 manually as r9344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698