Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1619483003: rebase expectations (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
vsm, ochafik
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

rebase expectations no changes here, just rebases against latest analyzer R=ochafik@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/7c2efeae77bd55c84e211dfe75c0170fa3a77d09

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1277 lines) Patch
M test/codegen/expect/collection/src/canonicalized_map.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D test/codegen/expect/collection/src/queue_list.js View 1 chunk +0 lines, -235 lines 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +2 lines, -0 lines 0 comments Download
D test/codegen/expect/collection/src/unmodifiable_wrappers.js View 1 chunk +0 lines, -229 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 chunk +2 lines, -0 lines 0 comments Download
D test/codegen/expect/collection/wrappers.js View 1 chunk +0 lines, -809 lines 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 11 months ago (2016-01-21 19:07:49 UTC) #2
vsm
lgtm, but i think we probably need generic method annotations in package:collection
4 years, 11 months ago (2016-01-21 19:16:11 UTC) #3
ochafik
lgtm LGTM
4 years, 11 months ago (2016-01-21 21:47:04 UTC) #4
Jennifer Messerly
4 years, 11 months ago (2016-01-22 21:16:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c2efeae77bd55c84e211dfe75c0170fa3a77d09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698