Source/core/html/HTMLSelectElement.h - Issue 16194013: Mouse press should focus on any types of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index bac7c088e333d55c9e3c2675494c1a01c31f521d..a2256f9f2d4f3b83157839f3a22d098575c8501b 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -114,7 +114,7 @@ private:

virtual const AtomicString& formControlType() const;

virtual bool isKeyboardFocusable(KeyboardEvent*) const;

- virtual bool isMouseFocusable() const;

+ virtual bool shouldShowFocusRingOnMouseFocus() const OVERRIDE;

virtual void dispatchFocusEvent(PassRefPtr<Node> oldFocusedNode, FocusDirection) OVERRIDE;

virtual void dispatchBlurEvent(PassRefPtr<Node> newFocusedNode);