Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/html/InputType.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/InputType.h ('k') | Source/core/html/TextFieldInputType.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 9 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
10 * 10 *
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 bool InputType::hasCustomFocusLogic() const 524 bool InputType::hasCustomFocusLogic() const
525 { 525 {
526 return true; 526 return true;
527 } 527 }
528 528
529 bool InputType::isKeyboardFocusable(KeyboardEvent* event) const 529 bool InputType::isKeyboardFocusable(KeyboardEvent* event) const
530 { 530 {
531 return element()->isTextFormControlKeyboardFocusable(event); 531 return element()->isTextFormControlKeyboardFocusable(event);
532 } 532 }
533 533
534 bool InputType::isMouseFocusable() const 534 bool InputType::shouldShowFocusRingOnMouseFocus() const
535 { 535 {
536 return element()->isTextFormControlMouseFocusable(); 536 return false;
537 } 537 }
538 538
539 bool InputType::shouldUseInputMethod() const 539 bool InputType::shouldUseInputMethod() const
540 { 540 {
541 return false; 541 return false;
542 } 542 }
543 543
544 void InputType::handleFocusEvent(Node*, FocusDirection) 544 void InputType::handleFocusEvent(Node*, FocusDirection)
545 { 545 {
546 } 546 }
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 1104
1105 void InputType::observeFeatureIfVisible(UseCounter::Feature feature) const 1105 void InputType::observeFeatureIfVisible(UseCounter::Feature feature) const
1106 { 1106 {
1107 if (RenderStyle* style = element()->renderStyle()) { 1107 if (RenderStyle* style = element()->renderStyle()) {
1108 if (style->visibility() != HIDDEN) 1108 if (style->visibility() != HIDDEN)
1109 UseCounter::count(element()->document(), feature); 1109 UseCounter::count(element()->document(), feature);
1110 } 1110 }
1111 } 1111 }
1112 1112
1113 } // namespace WebCore 1113 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/InputType.h ('k') | Source/core/html/TextFieldInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698