Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: Source/core/html/HTMLSelectElement.h

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 bool isParsingInProgress() const { return m_isParsingInProgress; } 109 bool isParsingInProgress() const { return m_isParsingInProgress; }
110 bool anonymousIndexedSetter(unsigned, PassRefPtr<HTMLOptionElement>, Excepti onCode&); 110 bool anonymousIndexedSetter(unsigned, PassRefPtr<HTMLOptionElement>, Excepti onCode&);
111 111
112 protected: 112 protected:
113 HTMLSelectElement(const QualifiedName&, Document*, HTMLFormElement*, bool cr eatedByParser); 113 HTMLSelectElement(const QualifiedName&, Document*, HTMLFormElement*, bool cr eatedByParser);
114 114
115 private: 115 private:
116 virtual const AtomicString& formControlType() const; 116 virtual const AtomicString& formControlType() const;
117 117
118 virtual bool isKeyboardFocusable(KeyboardEvent*) const; 118 virtual bool isKeyboardFocusable(KeyboardEvent*) const;
119 virtual bool isMouseFocusable() const; 119 virtual bool shouldShowFocusRingOnMouseFocus() const OVERRIDE;
120 120
121 virtual void dispatchFocusEvent(PassRefPtr<Node> oldFocusedNode, FocusDirect ion) OVERRIDE; 121 virtual void dispatchFocusEvent(PassRefPtr<Node> oldFocusedNode, FocusDirect ion) OVERRIDE;
122 virtual void dispatchBlurEvent(PassRefPtr<Node> newFocusedNode); 122 virtual void dispatchBlurEvent(PassRefPtr<Node> newFocusedNode);
123 123
124 virtual bool canStartSelection() const { return false; } 124 virtual bool canStartSelection() const { return false; }
125 125
126 virtual bool isEnumeratable() const { return true; } 126 virtual bool isEnumeratable() const { return true; }
127 virtual bool supportLabels() const OVERRIDE { return true; } 127 virtual bool supportLabels() const OVERRIDE { return true; }
128 128
129 virtual FormControlState saveFormControlState() const OVERRIDE; 129 virtual FormControlState saveFormControlState() const OVERRIDE;
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 { 221 {
222 ASSERT_WITH_SECURITY_IMPLICATION(!node || isHTMLSelectElement(node)); 222 ASSERT_WITH_SECURITY_IMPLICATION(!node || isHTMLSelectElement(node));
223 return static_cast<const HTMLSelectElement*>(node); 223 return static_cast<const HTMLSelectElement*>(node);
224 } 224 }
225 225
226 void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast. 226 void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast.
227 227
228 } // namespace 228 } // namespace
229 229
230 #endif 230 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698