Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLSelectElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 bool HTMLInputElement::hasCustomFocusLogic() const 358 bool HTMLInputElement::hasCustomFocusLogic() const
359 { 359 {
360 return m_inputType->hasCustomFocusLogic(); 360 return m_inputType->hasCustomFocusLogic();
361 } 361 }
362 362
363 bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const 363 bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const
364 { 364 {
365 return m_inputType->isKeyboardFocusable(event); 365 return m_inputType->isKeyboardFocusable(event);
366 } 366 }
367 367
368 bool HTMLInputElement::isMouseFocusable() const 368 bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const
369 { 369 {
370 return m_inputType->isMouseFocusable(); 370 return m_inputType->shouldShowFocusRingOnMouseFocus();
371 } 371 }
372 372
373 bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const 373 bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const
374 { 374 {
375 return HTMLTextFormControlElement::isKeyboardFocusable(event); 375 return HTMLTextFormControlElement::isKeyboardFocusable(event);
376 } 376 }
377 377
378 bool HTMLInputElement::isTextFormControlMouseFocusable() const
379 {
380 return HTMLTextFormControlElement::isMouseFocusable();
381 }
382
383 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection) 378 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection)
384 { 379 {
385 if (isTextField()) { 380 if (isTextField()) {
386 if (!restorePreviousSelection || !hasCachedSelection()) 381 if (!restorePreviousSelection || !hasCachedSelection())
387 select(); 382 select();
388 else 383 else
389 restoreCachedSelection(); 384 restoreCachedSelection();
390 if (document()->frame()) 385 if (document()->frame())
391 document()->frame()->selection()->revealSelection(); 386 document()->frame()->selection()->revealSelection();
392 } else 387 } else
(...skipping 1522 matching lines...) Expand 10 before | Expand all | Expand 10 after
1915 } 1910 }
1916 1911
1917 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1912 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1918 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1913 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1919 { 1914 {
1920 return m_inputType->customStyleForRenderer(originalStyleForRenderer()); 1915 return m_inputType->customStyleForRenderer(originalStyleForRenderer());
1921 } 1916 }
1922 #endif 1917 #endif
1923 1918
1924 } // namespace 1919 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLSelectElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698