Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: extensions/common/stack_frame.h

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more per Dmitry Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/stack_frame.h
diff --git a/extensions/common/stack_frame.h b/extensions/common/stack_frame.h
index 671f564a7c270a48f69a1f7519dff0c294600a01..b174ffc71ea47240321e4900b694adac774f0ec6 100644
--- a/extensions/common/stack_frame.h
+++ b/extensions/common/stack_frame.h
@@ -17,8 +17,8 @@ namespace extensions {
struct StackFrame {
StackFrame();
StackFrame(const StackFrame& frame);
- StackFrame(size_t line_number,
- size_t column_number,
+ StackFrame(uint32_t line_number,
+ uint32_t column_number,
const base::string16& source,
const base::string16& function);
~StackFrame();
@@ -29,8 +29,8 @@ struct StackFrame {
bool operator==(const StackFrame& rhs) const;
- size_t line_number;
- size_t column_number;
+ uint32_t line_number;
+ uint32_t column_number;
base::string16 source;
base::string16 function; // optional
};

Powered by Google App Engine
This is Rietveld 408576698