Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more per Dmitry Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 387a2c04afa24380c0fc610c0cdcea6c2a46a6e8..735ec1be38166a78b9855b4b1578fb4a50f78720 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2130,7 +2130,7 @@ void RenderFrameImpl::OnReload(bool ignore_cache) {
frame_->reload(ignore_cache);
}
-void RenderFrameImpl::OnTextSurroundingSelectionRequest(size_t max_length) {
+void RenderFrameImpl::OnTextSurroundingSelectionRequest(uint32_t max_length) {
blink::WebSurroundingText surroundingText;
surroundingText.initialize(frame_->selectionRange(), max_length);
@@ -2343,7 +2343,7 @@ void RenderFrameImpl::SetSelectedText(const base::string16& selection_text,
// Use the routing id of Render Widget Host.
Send(new ViewHostMsg_SelectionChanged(GetRenderWidget()->routing_id(),
selection_text,
- offset,
+ static_cast<uint32_t>(offset),
range));
}
@@ -2821,7 +2821,7 @@ void RenderFrameImpl::didAddMessageToConsole(
FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
DetailedConsoleMessageAdded(
message.text, source_name, stack_trace, source_line,
- static_cast<int32_t>(log_severity)));
+ static_cast<uint32_t>(log_severity)));
}
Send(new FrameHostMsg_AddMessageToConsole(

Powered by Google App Engine
This is Rietveld 408576698