content/common/fileapi/webblob_messages.h - Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/fileapi/webblob_messages.h

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more per Dmitry Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/fileapi/webblob_messages.h

diff --git a/content/common/fileapi/webblob_messages.h b/content/common/fileapi/webblob_messages.h

index a836fd4f5aec047c54f7c8fb3d04ae35460d7fcc..0dd31411d197a0bacf0d9636492a827245d20ce9 100644

--- a/content/common/fileapi/webblob_messages.h

+++ b/content/common/fileapi/webblob_messages.h

@@ -26,7 +26,7 @@ IPC_MESSAGE_CONTROL2(BlobHostMsg_AppendBlobDataItem,

IPC_SYNC_MESSAGE_CONTROL3_0(BlobHostMsg_SyncAppendSharedMemory,

std::string /*uuid*/,

base::SharedMemoryHandle,

- size_t /* buffer size */)

+ uint32_t /* buffer size */)

IPC_MESSAGE_CONTROL2(BlobHostMsg_FinishBuilding,

std::string /* uuid */,

std::string /* content_type */)

@@ -57,7 +57,7 @@ IPC_MESSAGE_CONTROL2(StreamHostMsg_AppendBlobDataItem,

IPC_SYNC_MESSAGE_CONTROL3_0(StreamHostMsg_SyncAppendSharedMemory,

GURL /* url */,

base::SharedMemoryHandle,

- size_t /* buffer size */)

+ uint32_t /* buffer size */)

// Flushes contents buffered in the stream.

IPC_MESSAGE_CONTROL1(StreamHostMsg_Flush,

« base/pickle.cc ('K') | « content/common/cc_messages.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »