Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: content/browser/fileapi/fileapi_message_filter.cc

Issue 1619363002: Add compile time checks against longs being used in IPC structs on 32 bit Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more per Dmitry Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/fileapi_message_filter.cc
diff --git a/content/browser/fileapi/fileapi_message_filter.cc b/content/browser/fileapi/fileapi_message_filter.cc
index bf8109d9d9cb5abc45344bb9fef3a8cfd0e9ad72..e52a4b2597cb9b46aa9bd31ca0b7914813adfb10 100644
--- a/content/browser/fileapi/fileapi_message_filter.cc
+++ b/content/browser/fileapi/fileapi_message_filter.cc
@@ -547,7 +547,7 @@ void FileAPIMessageFilter::OnAppendBlobDataItemToBlob(
void FileAPIMessageFilter::OnAppendSharedMemoryToBlob(
const std::string& uuid,
base::SharedMemoryHandle handle,
- size_t buffer_size) {
+ uint32_t buffer_size) {
DCHECK(base::SharedMemory::IsHandleValid(handle));
if (!buffer_size) {
bad_message::ReceivedBadMessage(
@@ -634,7 +634,8 @@ void FileAPIMessageFilter::OnAppendBlobDataItemToStream(
}
void FileAPIMessageFilter::OnAppendSharedMemoryToStream(
- const GURL& url, base::SharedMemoryHandle handle, size_t buffer_size) {
+ const GURL& url, base::SharedMemoryHandle handle,
+ uint32_t buffer_size) {
DCHECK(base::SharedMemory::IsHandleValid(handle));
if (!buffer_size) {
bad_message::ReceivedBadMessage(

Powered by Google App Engine
This is Rietveld 408576698