Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1619353002: [runtime] Make sure %ForInPrepare returns the correct length. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Make sure %ForInPrepare returns the correct length. In case the receiver map has an enum cache, %ForInPrepare returns the length of the actual enum cache, which might include properties that are further down the transition tree tho. R=jarin@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/56e1b13ea12fb2a9f4153b3cd0c7f86ab8bcc9cf Cr-Commit-Position: refs/heads/master@{#33469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M src/runtime/runtime-forin.cc View 1 chunk +5 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-3650-2.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-22 14:33:46 UTC) #1
Jarin
lgtm
4 years, 11 months ago (2016-01-22 14:37:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619353002/1
4 years, 11 months ago (2016-01-22 14:38:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 14:51:53 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 14:52:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56e1b13ea12fb2a9f4153b3cd0c7f86ab8bcc9cf
Cr-Commit-Position: refs/heads/master@{#33469}

Powered by Google App Engine
This is Rietveld 408576698