scripts/slave/recipe_modules/pgo/api.py - Issue 1619343003: Use the x64 version of pgosweep for the x64 PGO builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/pgo/api.py

Issue 1619343003: Use the x64 version of pgosweep for the x64 PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/pgo/api.py

diff --git a/scripts/slave/recipe_modules/pgo/api.py b/scripts/slave/recipe_modules/pgo/api.py

index aa39a595daf0ccb99958351ba383399dff513382..fa5f980557dfa3bed0408e4587968e2243842188 100644

--- a/scripts/slave/recipe_modules/pgo/api.py

+++ b/scripts/slave/recipe_modules/pgo/api.py

@@ -60,6 +60,9 @@ class PGOApi(recipe_api.RecipeApi):

"""

pgosweep_path = self.m.path['depot_tools'].join(

'win_toolchain', 'vs_files', 'VC', 'bin')

+ # Make sure that we're using the x64 version of pgosweep for the x64 builds.

+ if self.m.chromium.c.TARGET_BITS == 64:

+ pgosweep_path = pgosweep_path.join('amd64')

pgo_env = {

'PATH': '%s;%s;%s' % (

pgosweep_path, self.m.chromium.output_dir, '%(PATH)s'),

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json » ('j') | no next file with comments »