Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 161933002: Show IME when DPAD_CENTER is pressed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 11cfc9af8ca7fa069d01970574d7bc9c87a2492c..4b09417391c7e015917136601f6c0c55091d2879 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1818,6 +1818,12 @@ public class ContentViewCore
return mContainerViewInternals.super_dispatchKeyEvent(event);
}
+ if (event.getKeyCode() == KeyEvent.KEYCODE_DPAD_CENTER) {
+ showImeIfNeeded();
+ // Not consume it for now, pass it to IME. IME may interpret it as
aurimas (slooooooooow) 2014/02/13 00:43:23 The comment should say: // Event is not consumed h
jdduke (slow) 2014/02/13 00:57:03 Could you also briefly state in the comment that I
+ // "Enter" key.
+ }
+
if (mImeAdapter.dispatchKeyEvent(event)) return true;
return mContainerViewInternals.super_dispatchKeyEvent(event);

Powered by Google App Engine
This is Rietveld 408576698