Add Startup.SameVersionStartupCount histogram

Add Startup.SameVersionStartupCount histogram

BUG=580211
Committed: https://crrev.com/38c76899548104cb4b1639df94ffdc005e2cba8e
Cr-Commit-Position: refs/heads/master@{#371073}

[gab, 2016-01-22 15:46:01]

gab@chromium.org changed reviewers:
+ fdoray@chromium.org, thakis@chromium.org

[gab, 2016-01-22 15:46:02]

Francois PTAL.

@Nico for chrome_browser_main.cc and added DEPS from
components/startup_metric_utils to components/verson_info rubberstamp

[gab, 2016-01-22 15:49:36]

Description was changed from

==========
Add Startup.SameVersionStartupCount histogram

BUG=580211
==========

to

==========
Add Startup.SameVersionStartupCount histogram

BUG=580211
==========

[gab, 2016-01-22 15:49:36]

gab@chromium.org changed reviewers:
+ caitkp@chromium.org, jwd@chromium.org

[gab, 2016-01-22 15:50:49]

On 2016/01/22 15:46:02, gab wrote:
> Francois PTAL.
> 
> @Nico for chrome_browser_main.cc and added DEPS from
> components/startup_metric_utils to components/verson_info rubberstamp

+Jesse for histograms

+Cait for components/OWNERS (per-file addition for startup_metric_utils' gypi)

[Nico, 2016-01-22 15:59:18]

my stuff lgtm

[Cait (Slow), 2016-01-22 16:06:45]

components/OWNERS lgtm

[fdoray, 2016-01-22 16:08:54]

lgtm

https://codereview.chromium.org/1619273003/diff/40001/components/startup_metr...
File components/startup_metric_utils/browser/pref_names.cc (right):

https://codereview.chromium.org/1619273003/diff/40001/components/startup_metr...
components/startup_metric_utils/browser/pref_names.cc:10: // Time of the last
Chrome startup stored as an int64.
Is it ok to use Chrome in comments considering that startup_metric_utils is also
used by components/html_viewer?

[gab, 2016-01-22 16:50:54]

The CQ bit was checked by gab@chromium.org

[gab, 2016-01-22 16:50:54]

The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org,
thakis@chromium.org, caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/1619273003/#ps80001
(title: "comment nits")

[gab, 2016-01-22 16:50:59]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-01-22 16:51:44]

Thanks all, @jwd all yours for histograms :-)

https://codereview.chromium.org/1619273003/diff/40001/components/startup_metr...
File components/startup_metric_utils/browser/pref_names.cc (right):

https://codereview.chromium.org/1619273003/diff/40001/components/startup_metr...
components/startup_metric_utils/browser/pref_names.cc:10: // Time of the last
Chrome startup stored as an int64.
On 2016/01/22 16:08:54, fdoray wrote:
> Is it ok to use Chrome in comments considering that startup_metric_utils is
also
> used by components/html_viewer?

Good point, removed and also adapted existing comments (still a few instances
remaining in the .cc file around the 7-minutes stuff -- probably a good cleanup
for your pending 7minutes CL).

[jwd, 2016-01-22 21:18:37]

lgtm

[gab, 2016-01-22 21:27:15]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-01-22 21:28:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619273003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619273003/80001

[commit-bot: I haz the power, 2016-01-22 21:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 21:31:45]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-01-22 21:49:47]

The CQ bit was checked by gab@chromium.org

[gab, 2016-01-22 21:49:47]

The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org,
thakis@chromium.org, jwd@chromium.org, caitkp@chromium.org
Link to the patchset: https://codereview.chromium.org/1619273003/#ps100001
(title: "merge")

[commit-bot: I haz the power, 2016-01-22 21:50:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619273003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619273003/100001

[commit-bot: I haz the power, 2016-01-22 23:27:03]

Description was changed from

==========
Add Startup.SameVersionStartupCount histogram

BUG=580211
==========

to

==========
Add Startup.SameVersionStartupCount histogram

BUG=580211
==========

[commit-bot: I haz the power, 2016-01-22 23:27:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-22 23:28:32]

Description was changed from

==========
Add Startup.SameVersionStartupCount histogram

BUG=580211
==========

to

==========
Add Startup.SameVersionStartupCount histogram

BUG=580211

Committed: https://crrev.com/38c76899548104cb4b1639df94ffdc005e2cba8e
Cr-Commit-Position: refs/heads/master@{#371073}
==========

[commit-bot: I haz the power, 2016-01-22 23:28:33]

Patchset 6 (id:??) landed as
https://crrev.com/38c76899548104cb4b1639df94ffdc005e2cba8e
Cr-Commit-Position: refs/heads/master@{#371073}