Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1619253003: Include explicit constructors and static methods into UnlinkedPublicName (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index 7738b50687b8f093f3ceb843a941c78b861b3ba2..9bcb40d41d4238ace4ccd281c2253ada001c8125 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -43,19 +43,52 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
_PublicNamespaceVisitor();
- void addNameIfPublic(String name, ReferenceKind kind, int numTypeParameters) {
+ UnlinkedPublicNameBuilder addNameIfPublic(
+ String name, ReferenceKind kind, int numTypeParameters) {
if (isPublic(name)) {
- names.add(new UnlinkedPublicNameBuilder(
- name: name, kind: kind, numTypeParameters: numTypeParameters));
+ UnlinkedPublicNameBuilder b = new UnlinkedPublicNameBuilder(
+ name: name, kind: kind, numTypeParameters: numTypeParameters);
+ names.add(b);
+ return b;
}
+ return null;
}
bool isPublic(String name) => !name.startsWith('_');
@override
visitClassDeclaration(ClassDeclaration node) {
- addNameIfPublic(node.name.name, ReferenceKind.classOrEnum,
+ UnlinkedPublicNameBuilder cls = addNameIfPublic(
+ node.name.name,
+ ReferenceKind.classOrEnum,
node.typeParameters?.typeParameters?.length ?? 0);
+ if (cls != null) {
+ for (ClassMember member in node.members) {
+ if (member is MethodDeclaration &&
+ member.isStatic &&
+ !member.isGetter &&
+ !member.isSetter &&
+ !member.isOperator) {
+ String name = member.name.name;
+ if (isPublic(name)) {
+ cls.executables.add(new UnlinkedPublicNameBuilder(
+ name: name,
+ kind: ReferenceKind.staticMethod,
+ numTypeParameters:
+ member.typeParameters?.typeParameters?.length ?? 0));
+ }
+ }
+ if (member is ConstructorDeclaration) {
+ String name = member.name != null ? member.name.name : '';
+ if (isPublic(name)) {
+ cls.executables.add(new UnlinkedPublicNameBuilder(
+ name: name,
+ kind: ReferenceKind.constructor,
+ numTypeParameters: 0));
+ }
+ }
+ }
+ }
}
@override

Powered by Google App Engine
This is Rietveld 408576698