Include explicit constructors and static methods into UnlinkedPublicName

Include explicit constructors and static methods into UnlinkedPublicName

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/013f0066ff444aad9e3ab98051358af6c570d465

[Paul Berry, 2016-01-25 13:10:05]

lgtm with one minor nit.

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:638: // and they always refer to
defined entities.
s/defined entities/defined top level entities/

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:579: if (method.isStatic &&
method.isPublic) {
Do we need to filter out operators or does `method.isPublic` do that?

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1054: static void
methodStaticPublic() {}
I'd recommend adding a line like this:

"C operator+(C c) => null;"

so that we verify that operators are not included in executablesMap.

[scheglov, 2016-01-25 17:27:09]

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:638: // and they always refer to
defined entities.
On 2016/01/25 13:10:04, Paul Berry wrote:
> s/defined entities/defined top level entities/

Done.

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:579: if (method.isStatic &&
method.isPublic) {
On 2016/01/25 13:10:04, Paul Berry wrote:
> Do we need to filter out operators or does `method.isPublic` do that?

Operators cannot be static, so we don't have static operator MethodElement(s).

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1619253003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1054: static void
methodStaticPublic() {}
On 2016/01/25 13:10:04, Paul Berry wrote:
> I'd recommend adding a line like this:
> 
> "C operator+(C c) => null;"
> 
> so that we verify that operators are not included in executablesMap.

Done.

[scheglov, 2016-01-25 17:27:27]

Description was changed from

==========
Include explicit constructors and static methods into UnlinkedPublicName

R=paulberry@google.com
BUG=
==========

to

==========
Include explicit constructors and static methods into UnlinkedPublicName

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/013f0066ff444aad9e3ab98051358af6c570d465
==========

[scheglov, 2016-01-25 17:27:28]

Committed patchset #1 (id:1) manually as
013f0066ff444aad9e3ab98051358af6c570d465 (presubmit successful).