bluetooth: README.md and Android Fakes.java documentation.

bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.

Committed: https://crrev.com/0a0dc888b0f33a78b38572873764410ac2c730b3
Cr-Commit-Position: refs/heads/master@{#371947}

[scheib, 2016-01-22 05:52:47]

Description was changed from

==========
bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.
==========

to

==========
bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.
==========

[scheib, 2016-01-22 05:52:47]

scheib@chromium.org changed reviewers:
+ armansito@chromium.org, jyasskin@chromium.org, ortuno@chromium.org,
rpaquay@chromium.org

[scheib, 2016-01-22 05:54:26]

Arman, Renaud, please correct anything - but particularly comment if I got the
previous implementation status incorrect in platforms.

All, please suggest anything else that should be in device/bluetooth/README.md.

[ortuno, 2016-01-26 20:40:05]

lgtm

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README.md
File device/bluetooth/README.md (right):

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:10: implementations may support only one or the
other. even though several classes
... or the other, even though...

[Jeffrey Yasskin, 2016-01-26 20:59:38]

Thanks for doing this! lgtm.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README.md
File device/bluetooth/README.md (right):

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:48: Implementation of the Bluetooth component is
tested via unittests. Client code
Want to mention that only ChromeOS has full-system tests, managed by the
ChromeOS team?

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:54: New feature development uses cross platform unit
tests. This reduces test code
Mention that these unit tests mock out the calls to the underlying platform, as
close to the platform as possible.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:66: platform specific unit tests, e.g.
`bluetooth_bluez_unittest.cc` &
Maybe mention that these tests often asked the platform to expose fake devices,
and then interacted with those through the platform?

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:76: `test/mock_bluetooth_*` files provide GMOCK based
fake objects for use in client
"GMock" isn't normally all-caps. Its official name is "GoogleMock" now
(https://github.com/google/googletest), but the abbreviation is ok.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:93: and __fakes__ implemenated in:
sp: implemenated

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:98: * `bluetooth_adapter_android.h` owns:
Yay clarity!

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:106: * `bluetooth_gatt_service_android.h` owns:
Maybe a "* similar through characteristics and descriptors" item.

[rpaquay, 2016-01-27 00:21:17]

lgtm

[scheib, 2016-01-27 23:59:06]

Thanks.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README.md
File device/bluetooth/README.md (right):

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:10: implementations may support only one or the
other. even though several classes
On 2016/01/26 20:40:04, ortuno wrote:
> ... or the other, even though...

Done.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:48: Implementation of the Bluetooth component is
tested via unittests. Client code
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> Want to mention that only ChromeOS has full-system tests, managed by the
> ChromeOS team?

Done.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:54: New feature development uses cross platform unit
tests. This reduces test code
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> Mention that these unit tests mock out the calls to the underlying platform,
as
> close to the platform as possible.

Done.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:66: platform specific unit tests, e.g.
`bluetooth_bluez_unittest.cc` &
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> Maybe mention that these tests often asked the platform to expose fake
devices,
> and then interacted with those through the platform?

Done.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:76: `test/mock_bluetooth_*` files provide GMOCK based
fake objects for use in client
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> "GMock" isn't normally all-caps. Its official name is "GoogleMock" now
> (https://github.com/google/googletest), but the abbreviation is ok.

Done.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:93: and __fakes__ implemenated in:
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> sp: implemenated

Done.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:98: * `bluetooth_adapter_android.h` owns:
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> Yay clarity!

Acknowledged.

https://codereview.chromium.org/1619173002/diff/20001/device/bluetooth/README...
device/bluetooth/README.md:106: * `bluetooth_gatt_service_android.h` owns:
On 2016/01/26 20:59:37, Jeffrey Yasskin wrote:
> Maybe a "* similar through characteristics and descriptors" item.

Done.

[scheib, 2016-01-27 23:59:18]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-01-27 23:59:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, ortuno@chromium.org, rpaquay@chromium.org
Link to the patchset: https://codereview.chromium.org/1619173002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-01-27 23:59:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619173002/40001

[commit-bot: I haz the power, 2016-01-28 00:54:58]

Description was changed from

==========
bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.
==========

to

==========
bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.
==========

[commit-bot: I haz the power, 2016-01-28 00:54:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 01:16:31]

Description was changed from

==========
bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.
==========

to

==========
bluetooth: README.md and Android Fakes.java documentation.

Initial high level documentation for device/bluetooth.

Committed: https://crrev.com/0a0dc888b0f33a78b38572873764410ac2c730b3
Cr-Commit-Position: refs/heads/master@{#371947}
==========

[commit-bot: I haz the power, 2016-01-28 01:16:32]

Patchset 3 (id:??) landed as
https://crrev.com/0a0dc888b0f33a78b38572873764410ac2c730b3
Cr-Commit-Position: refs/heads/master@{#371947}