Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1983)

Unified Diff: chrome/browser/resources/ntp4/apps_page.js

Issue 16191003: Add enable-app-shims to chrome://flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Need #if defined(OS_MACOSX) in ntp_resource_cache.cc Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/apps_page.js
diff --git a/chrome/browser/resources/ntp4/apps_page.js b/chrome/browser/resources/ntp4/apps_page.js
index 852887d79efd671f1b2e53c2e230620d9d6811b6..8a9ab9594bc21671ca293735f3cad940119ddad6 100644
--- a/chrome/browser/resources/ntp4/apps_page.js
+++ b/chrome/browser/resources/ntp4/apps_page.js
@@ -73,7 +73,7 @@ cr.define('ntp', function() {
this.uninstall_.addEventListener('activate',
this.onUninstall_.bind(this));
- if (!(cr.isChromeOS || cr.isMac)) {
+ if (!cr.isChromeOS) {
this.createShortcutSeparator_ =
menu.appendChild(cr.ui.MenuItem.createSeparator());
this.createShortcut_ = this.appendMenuItem_('appcreateshortcut');
@@ -140,12 +140,13 @@ cr.define('ntp', function() {
this.details_.disabled = !app.appData.detailsUrl;
this.uninstall_.disabled = !app.appData.mayDisable;
- if (this.createShortcut_ && cr.isMac) {
Dan Beam 2013/05/30 22:19:25 what changed about this property being present?
jackhou1 2013/05/30 23:07:18 Previously, this line would never be true due to l
+ if (cr.isMac) {
// On Windows and Linux, these should always be visible. On ChromeOS,
// they are never created. On Mac, shortcuts can only be created for
// new-style packaged apps, so hide the menu item.
Dan Beam 2013/05/30 22:19:25 ^ does this comment need to be updated?
jackhou1 2013/05/30 23:07:18 Done.
this.createShortcutSeparator_.hidden = this.createShortcut_.hidden =
- !app.appData.packagedApp;
+ !app.appData.packagedApp ||
+ loadTimeData.getBoolean('disableCreateAppShortcut');
}
},
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698