Issue 16190008: Fast literals: fixed initialization of non-copied in-object property fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16190008: Fast literals: fixed initialization of non-copied in-object property fields (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fast literals: fixed initialization of non-copied in-object property fields BUG=chromium:245424 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14906

Patch Set 2 : addressed comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -15 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-245424.js	View	1	1 chunk	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one comment. https://codereview.chromium.org/16190008/diff/1/test/mjsunit/regress/regress-crbug-245424.js File test/mjsunit/regress/regress-crbug-245424.js (right): https://codereview.chromium.org/16190008/diff/1/test/mjsunit/regress/regress-crbug-245424.js#newcode38 test/mjsunit/regress/regress-crbug-245424.js:38: print(boom().foo); Let's turn the "print" ...

7 years, 6 months ago (2013-05-31 15:46:07 UTC) #2

Jakob Kummerow

Landing. https://codereview.chromium.org/16190008/diff/1/test/mjsunit/regress/regress-crbug-245424.js File test/mjsunit/regress/regress-crbug-245424.js (right): https://codereview.chromium.org/16190008/diff/1/test/mjsunit/regress/regress-crbug-245424.js#newcode38 test/mjsunit/regress/regress-crbug-245424.js:38: print(boom().foo); On 2013/05/31 15:46:07, Michael Starzinger wrote: > ...

7 years, 6 months ago (2013-05-31 15:50:01 UTC) #3

Jakob Kummerow

7 years, 6 months ago (2013-05-31 15:50:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14906 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16190008: Fast literals: fixed initialization of non-copied in-object property fields (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages