drive: Add DownloadOperation::EnsureFileDownloadedByResourceId

chrome/browser/chromeos/drive/file_system/download_operation.h

Index: chrome/browser/chromeos/drive/file_system/download_operation.h
diff --git a/chrome/browser/chromeos/drive/file_system/download_operation.h b/chrome/browser/chromeos/drive/file_system/download_operation.h
index 5a1b43a17699d6e73bb5f28212eaad472224c746..274e165a01465382771349e87806eb1e0e2eddd2 100644
--- a/chrome/browser/chromeos/drive/file_system/download_operation.h
+++ b/chrome/browser/chromeos/drive/file_system/download_operation.h
@@ -61,7 +61,16 @@ class DownloadOperation {
   // |initialized_callback| and |get_content_callback| can be null if not
   // needed.
   // |completion_callback| must not be null.
-  void EnsureFileDownloaded(
+  void EnsureFileDownloadedByResourceId(

[satorux1, 2013/05/30 01:14:35]

Could you add a test for this function? you might want to introduce
download_operation_unittest.cc first... kinaba@ is in the process of moving test
code from file_system_unittest.cc to file_system/*_unittest.cc, so he may have
already started doing this for download_operation.

if it's too much of hassle, you can file a bug and do it later.  

[hashimoto, 2013/05/30 01:47:25]

This method is tested by FileSystemTest.GetFileByResourceID*.
To make independent unit test for download_operation.cc, kinaba@ has filed
http://crbug.com/244344.

+      const std::string& resource_id,
+      const ClientContext& context,
+      const GetFileContentInitializedCallback& initialized_callback,
+      const google_apis::GetContentCallback& get_content_callback,
+      const GetFileCallback& completion_callback);
+
+  // Does the same thing as EnsureFileDownloadedByResourceId for the file
+  // specified with |file_path|.
+  void EnsureFileDownloadedByPath(
       const base::FilePath& file_path,
       const ClientContext& context,
       const GetFileContentInitializedCallback& initialized_callback,
@@ -78,7 +87,6 @@ class DownloadOperation {
   // Part of EnsureFileDownloaded(). Called upon the completion of precondition
   // check.
   void EnsureFileDownloadedAfterCheckPreCondition(
-      const base::FilePath& file_path,
       const ClientContext& context,
       const DownloadCallback& callback,
       scoped_ptr<ResourceEntry> entry,