cc: Add new RasterWorkerPool interface.

cc/resources/managed_tile_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_MANAGED_TILE_STATE_H_
 #define CC_RESOURCES_MANAGED_TILE_STATE_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "cc/resources/platform_color.h"
 #include "cc/resources/raster_worker_pool.h"
@@ skipping 27 matching lines @@
       ~TileVersion();
 
       Mode mode() const {
         return mode_;
       }
 
       bool IsReadyToDraw() const;
 
       ResourceProvider::ResourceId get_resource_id() const {
         DCHECK(mode_ == RESOURCE_MODE);
-        DCHECK(resource_);
+        DCHECK(resource_id_);
         DCHECK(memory_state_ == USING_RELEASABLE_MEMORY || forced_upload_);
-        return resource_->id();
+        return resource_id_;

[enne (OOO), 2013/05/30 19:38:31]

Sorry for such a naive question, but I'm not sure I follow why resource_id_
needs to be stored separately from resource_? Can resource_->id() !=
resource_id_?

[reveman, 2013/05/30 23:25:18]

This is because of the current force upload mess. Force upload allows us to draw
using the resource but the ownership of the resource need to stay with the
RasterWorkerPool as it still has shared memory attached to it that can't be
released. We're planning to fix this but it will require some significant
changes to the ResourceProvider's pixel buffer API.

[enne (OOO), 2013/05/31 17:05:38]

Ok, thanks.  Can you add a FIXME here and some comment about when resource_id_
might not equal resource_? I'm sure somebody else will have the same question
when looking at this code.

[reveman, 2013/06/01 03:02:38]

Done.

       }
 
       SkColor get_solid_color() const {
         DCHECK(mode_ == SOLID_COLOR_MODE);
 
         return solid_color_;
       }
 
       bool contents_swizzled() const {
         return !PlatformColor::SameComponentOrder(resource_format_);
@@ skipping 22 matching lines @@
       void set_use_resource() {
         mode_ = RESOURCE_MODE;
         if (memory_state_ == NOT_ALLOWED_TO_USE_MEMORY)
           memory_state_ = CAN_USE_MEMORY;
       }
 
       void set_solid_color(const SkColor& color) {
         mode_ = SOLID_COLOR_MODE;
         solid_color_ = color;
         memory_state_ = NOT_ALLOWED_TO_USE_MEMORY;
+        resource_id_ = 0;
       }
 
       void set_rasterize_on_demand() {
         mode_ = PICTURE_PILE_MODE;
         memory_state_ = NOT_ALLOWED_TO_USE_MEMORY;
+        resource_id_ = 0;
       }
 
       Mode mode_;
       SkColor solid_color_;
 
+      ResourceProvider::ResourceId resource_id_;
       scoped_ptr<ResourcePool::Resource> resource_;
       GLenum resource_format_;
       TileVersionMemoryState memory_state_;
       bool forced_upload_;
   };
 
 
   ManagedTileState();
   ~ManagedTileState();
 
   scoped_ptr<base::Value> AsValue() const;
 
   // Persisted state: valid all the time.
   TileVersion tile_version;
   bool picture_pile_analyzed;
   PicturePileImpl::Analysis picture_pile_analysis;
-  RasterWorkerPool::Task raster_task;
+  RasterWorkerPool::RasterTask raster_task;
 
   // Ephemeral state, valid only during TileManager::ManageTiles.
   bool is_in_never_bin_on_both_trees() const {
     return bin[HIGH_PRIORITY_BIN] == NEVER_BIN &&
            bin[LOW_PRIORITY_BIN] == NEVER_BIN;
   }
   bool is_in_now_bin_on_either_tree() const {
     return bin[HIGH_PRIORITY_BIN] == NOW_BIN ||
            bin[LOW_PRIORITY_BIN] == NOW_BIN;
   }
 
   TileManagerBin bin[NUM_BIN_PRIORITIES];
   TileManagerBin tree_bin[NUM_TREES];
 
   // The bin that the tile would have if the GPU memory manager had
   // a maximally permissive policy, send to the GPU memory manager
   // to determine policy.
   TileManagerBin gpu_memmgr_stats_bin;
   TileResolution resolution;
   bool required_for_activation;
   float time_to_needed_in_seconds;
   float distance_to_visible_in_pixels;
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_MANAGED_TILE_STATE_H_