mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl - Issue 1618963006: Mojo C++ bindings: support enum validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

Issue 1618963006: Mojo C++ bindings: support enum validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

index 5cb1dc8b68d1293e50013ac5e27ef1dafea74bb9..99731fb5e0a3bb9d3a959c27283416a950920c71 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

@@ -41,6 +41,11 @@ if (!{{field.kind|cpp_wrapper_type}}::Data_::Validate(

}

{%- endmacro -%}

+{%- macro validate_enum(field_expr, field) -%}

+if (!mojo::internal::ValidateEnum(*{{field_expr}}))

+ return false;

+{%- endmacro -%}

{%- macro validate_union_field(field, union) %}

{%- set field_expr = "(reinterpret_cast<const "

~ field.kind|cpp_union_field_type

@@ -61,5 +66,9 @@ if (!{{field.kind|cpp_wrapper_type}}::Data_::Validate(

{%- if field.kind|is_any_handle_kind -%}

{%- endif %}

+{%- if field.kind|is_enum_kind -%}

+{{ validate_enum(field_expr, field) }}

+{%- endif %}

return true;

{%- endmacro %}