mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl - Issue 1618963006: Mojo C++ bindings: support enum validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl

Issue 1618963006: Mojo C++ bindings: support enum validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl

index 52aafacc0456f17515b206962e3c5f2ccda05923..1fd9cf38cd2f513807a1e511fe9d90c93b4e1236 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl

@@ -33,7 +33,7 @@ class {{struct.name}}_Reader {

// TODO(rockot): Support reading associated kinds. ({{name}}() omitted)

{%- elif kind|is_enum_kind %}

{{kind|cpp_result_type}} {{name}}() const {

- return static_cast<{{kind|cpp_result_type}}>(data_->{{name}});

+ return static_cast<{{kind|cpp_result_type}}>(data_->{{name}}.value);

}

{%- else %}

{{kind|cpp_result_type}} {{name}}() const { return data_->{{name}}; }