Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: mojo/public/cpp/bindings/lib/bindings_internal.h

Issue 1618963006: Mojo C++ bindings: support enum validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/array_internal.h ('k') | mojo/public/cpp/bindings/lib/validation_errors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/bindings_internal.h
diff --git a/mojo/public/cpp/bindings/lib/bindings_internal.h b/mojo/public/cpp/bindings/lib/bindings_internal.h
index 6d2562f1b585fa710d9cf892776c721f9b29f4dc..6786d4dfc828390a0713bcec1dc192e16b552564 100644
--- a/mojo/public/cpp/bindings/lib/bindings_internal.h
+++ b/mojo/public/cpp/bindings/lib/bindings_internal.h
@@ -94,6 +94,8 @@ struct IsHandle {
template <typename T>
struct IsUnionDataType {
+ typedef char (*EnsureTypeIsComplete)[sizeof(T)];
Ken Rockot(use gerrit already) 2016/01/26 15:39:20 nit: any reason not to use a c++11 alias here and
yzshen1 2016/01/26 18:16:04 Done. I also refactored a little bit. Thanks!
+
template <typename U>
static YesType Test(const typename U::MojomUnionDataType*);
@@ -104,6 +106,20 @@ struct IsUnionDataType {
sizeof(Test<T>(0)) == sizeof(YesType) && !IsConst<T>::value;
};
+template <typename T>
+struct IsEnumDataType {
+ typedef char (*EnsureTypeIsComplete)[sizeof(T)];
+
+ template <typename U>
+ static YesType Test(const typename U::MojomEnumDataType*);
+
+ template <typename U>
+ static NoType Test(...);
+
+ static const bool value =
+ sizeof(Test<T>(0)) == sizeof(YesType) && !IsConst<T>::value;
+};
+
template <typename T, bool move_only = IsMoveOnlyType<T>::value>
struct WrapperTraits;
« no previous file with comments | « mojo/public/cpp/bindings/lib/array_internal.h ('k') | mojo/public/cpp/bindings/lib/validation_errors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698