Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: mojo/public/js/validation_unittests.js

Issue 1618963006: Mojo C++ bindings: support enum validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 define([ 5 define([
6 "console", 6 "console",
7 "file", 7 "file",
8 "gin/test/expect", 8 "gin/test/expect",
9 "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom", 9 "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom",
10 "mojo/public/js/buffer", 10 "mojo/public/js/buffer",
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 220
221 function testMessageValidation(prefix, filters) { 221 function testMessageValidation(prefix, filters) {
222 var testFiles = getMessageTestFiles(prefix); 222 var testFiles = getMessageTestFiles(prefix);
223 expect(testFiles.length).toBeGreaterThan(0); 223 expect(testFiles.length).toBeGreaterThan(0);
224 224
225 for (var i = 0; i < testFiles.length; i++) { 225 for (var i = 0; i < testFiles.length; i++) {
226 // TODO(hansmuller) Temporarily skipping array pointer overflow tests 226 // TODO(hansmuller) Temporarily skipping array pointer overflow tests
227 // because JS numbers are limited to 53 bits. 227 // because JS numbers are limited to 53 bits.
228 // TODO(yzshen) Skipping struct versioning tests (tests with "mthd11" 228 // TODO(yzshen) Skipping struct versioning tests (tests with "mthd11"
229 // in the name) because the feature is not supported in JS yet. 229 // in the name) because the feature is not supported in JS yet.
230 // TODO(yzshen) Skipping enum validation tests (tests with "enum" in the
231 // name) because the feature is not supported in JS yet. crbug.com/581390
230 // TODO(rudominer): Temporarily skipping 'no-such-method', 232 // TODO(rudominer): Temporarily skipping 'no-such-method',
231 // 'invalid_request_flags', and 'invalid_response_flags' until additional 233 // 'invalid_request_flags', and 'invalid_response_flags' until additional
232 // logic in *RequestValidator and *ResponseValidator is ported from 234 // logic in *RequestValidator and *ResponseValidator is ported from
233 // cpp to js. 235 // cpp to js.
234 if (testFiles[i].indexOf("overflow") != -1 || 236 if (testFiles[i].indexOf("overflow") != -1 ||
235 testFiles[i].indexOf("mthd11") != -1 || 237 testFiles[i].indexOf("mthd11") != -1 ||
238 testFiles[i].indexOf("enum") != -1 ||
236 testFiles[i].indexOf("no_such_method") != -1 || 239 testFiles[i].indexOf("no_such_method") != -1 ||
237 testFiles[i].indexOf("invalid_request_flags") != -1 || 240 testFiles[i].indexOf("invalid_request_flags") != -1 ||
238 testFiles[i].indexOf("invalid_response_flags") != -1) { 241 testFiles[i].indexOf("invalid_response_flags") != -1) {
239 console.log("[Skipping " + testFiles[i] + "]"); 242 console.log("[Skipping " + testFiles[i] + "]");
240 continue; 243 continue;
241 } 244 }
242 245
243 var testMessage = readTestMessage(testFiles[i]); 246 var testMessage = readTestMessage(testFiles[i]);
244 var handles = new Array(testMessage.handleCount); 247 var handles = new Array(testMessage.handleCount);
245 var message = new codec.Message(testMessage.buffer, handles); 248 var message = new codec.Message(testMessage.buffer, handles);
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 testConformanceMessageValidation(); 340 testConformanceMessageValidation();
338 testBoundsCheckMessageValidation(); 341 testBoundsCheckMessageValidation();
339 testResponseConformanceMessageValidation(); 342 testResponseConformanceMessageValidation();
340 testResponseBoundsCheckMessageValidation(); 343 testResponseBoundsCheckMessageValidation();
341 testIntegratedMessageHeaderValidation(); 344 testIntegratedMessageHeaderValidation();
342 testIntegratedResponseMessageValidation(); 345 testIntegratedResponseMessageValidation();
343 testIntegratedRequestMessageValidation(); 346 testIntegratedRequestMessageValidation();
344 347
345 this.result = "PASS"; 348 this.result = "PASS";
346 }); 349 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698