Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1618823002: Add myself as per-file OWNER for CharacterNames.h (Closed)

Created:
4 years, 11 months ago by drott
Modified:
4 years, 11 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add myself as per-file OWNER for CharacterNames.h We often need to touch this file for text & layout work. It has a big overlap with work in Source/platform/fonts. I would like to avoid being slowed down by waiting for wtf/ OWNERs for these changes. Thanks. BUG= Committed: https://crrev.com/c3bc9ee96e21f2b7b1fb4952b03b8124b1734b30 Cr-Commit-Position: refs/heads/master@{#370710}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/wtf/OWNERS View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (3 generated)
drott
4 years, 11 months ago (2016-01-21 14:59:43 UTC) #2
Nico
lgtm
4 years, 11 months ago (2016-01-21 15:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618823002/1
4 years, 11 months ago (2016-01-21 15:24:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 16:16:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3bc9ee96e21f2b7b1fb4952b03b8124b1734b30 Cr-Commit-Position: refs/heads/master@{#370710}
4 years, 11 months ago (2016-01-21 16:17:23 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-21 16:17:32 UTC) #9
drott
https://codereview.chromium.org/1618823002/diff/1/third_party/WebKit/Source/wtf/OWNERS File third_party/WebKit/Source/wtf/OWNERS (right): https://codereview.chromium.org/1618823002/diff/1/third_party/WebKit/Source/wtf/OWNERS#newcode10 third_party/WebKit/Source/wtf/OWNERS:10: per-file CharacterNames.h=drott@chromium.org Do I need to specify text/CharacterNames.h here? ...
4 years, 11 months ago (2016-01-22 14:57:47 UTC) #10
Peter Beverloo
On 2016/01/22 14:57:47, drott wrote: > https://codereview.chromium.org/1618823002/diff/1/third_party/WebKit/Source/wtf/OWNERS > File third_party/WebKit/Source/wtf/OWNERS (right): > > https://codereview.chromium.org/1618823002/diff/1/third_party/WebKit/Source/wtf/OWNERS#newcode10 > ...
4 years, 11 months ago (2016-01-22 15:09:18 UTC) #11
Nico
On 2016/01/22 15:09:18, Peter Beverloo wrote: > On 2016/01/22 14:57:47, drott wrote: > > > ...
4 years, 11 months ago (2016-01-22 15:10:40 UTC) #12
drott
4 years, 11 months ago (2016-01-22 15:12:06 UTC) #13
Message was sent while issue was closed.
Nico, Peter, thanks for your help, I'll update it accordingly.

Powered by Google App Engine
This is Rietveld 408576698