Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1618753002: Revert of [regexp] implement character classes for unicode regexps. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] implement character classes for unicode regexps. (patchset #11 id:220001 of https://codereview.chromium.org/1578253005/ ) Reason for revert: Compile failure on arm. https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7341/steps/compile/logs/stdio Original issue's description: > [regexp] implement character classes for unicode regexps. > > We divide character ranges into > - BMP, matched normally. > - non-BMP, matched as alternatives of surrogate pair ranges. > - lone surrogates, matched with lookaround assertion that its indeed lone. > > R=erik.corry@gmail.com > BUG=v8:2952 > LOG=N > > Committed: https://crrev.com/ea820ad5fa282a323a86fe20e64f83ee67ba5f04 > Cr-Commit-Position: refs/heads/master@{#33432} TBR=littledan@chromium.org,erik.corry@gmail.com,erikcorry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2952 Committed: https://crrev.com/4de91c5367ff7dd698506b1fd9879ae85614daf1 Cr-Commit-Position: refs/heads/master@{#33434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -922 lines) Patch
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ostreams.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/ostreams.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/regexp/jsregexp.h View 6 chunks +15 lines, -53 lines 0 comments Download
M src/regexp/jsregexp.cc View 31 chunks +150 lines, -409 lines 0 comments Download
M src/regexp/regexp-ast.h View 5 chunks +15 lines, -37 lines 0 comments Download
M src/regexp/regexp-ast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp/regexp-parser.h View 7 chunks +9 lines, -21 lines 0 comments Download
M src/regexp/regexp-parser.cc View 26 chunks +51 lines, -141 lines 0 comments Download
M test/cctest/test-regexp.cc View 11 chunks +33 lines, -58 lines 0 comments Download
D test/mjsunit/harmony/unicode-character-ranges.js View 1 chunk +0 lines, -149 lines 0 comments Download
M test/mjsunit/harmony/unicode-escapes-in-regexps.js View 1 chunk +1 line, -25 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [regexp] implement character classes for unicode regexps.
4 years, 11 months ago (2016-01-21 12:37:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618753002/1
4 years, 11 months ago (2016-01-21 12:37:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 12:37:54 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 12:38:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4de91c5367ff7dd698506b1fd9879ae85614daf1
Cr-Commit-Position: refs/heads/master@{#33434}

Powered by Google App Engine
This is Rietveld 408576698