Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 161873002: Remove unused includes & using statements from blink::Platform implementations. (Closed)

Created:
6 years, 10 months ago by ddorwin
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove unused includes & using statements from blink::Platform implementations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250945

Patch Set 1 #

Patch Set 2 : removed temp comment #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M content/child/webkitplatformsupport_child_impl.cc View 1 1 chunk +2 lines, -2 lines 4 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/child/webkitplatformsupport_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ddorwin
abarth, all of the removals are public/web in files implementing public/platform/Platform.h. There is only one ...
6 years, 10 months ago (2014-02-12 23:33:46 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/161873002/diff/40001/content/child/webkitplatformsupport_child_impl.cc File content/child/webkitplatformsupport_child_impl.cc (right): https://codereview.chromium.org/161873002/diff/40001/content/child/webkitplatformsupport_child_impl.cc#newcode77 content/child/webkitplatformsupport_child_impl.cc:77: if (device_source == blink::WebGestureEvent::Touchscreen) On 2014/02/12 23:33:46, ddorwin ...
6 years, 10 months ago (2014-02-12 23:37:22 UTC) #2
ddorwin
darin, please OWNERS review this tiny code removal URL already approved by abarth@. https://codereview.chromium.org/161873002/diff/40001/content/child/webkitplatformsupport_child_impl.cc File ...
6 years, 10 months ago (2014-02-12 23:49:29 UTC) #3
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-13 00:00:01 UTC) #4
ddorwin
The CQ bit was checked by ddorwin@chromium.org
6 years, 10 months ago (2014-02-13 01:07:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/161873002/40001
6 years, 10 months ago (2014-02-13 01:09:22 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 04:34:30 UTC) #7
Message was sent while issue was closed.
Change committed as 250945

Powered by Google App Engine
This is Rietveld 408576698