Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1618713003: Use the alternate notification UI for Mac (Closed)

Created:
4 years, 11 months ago by Miguel Garcia
Modified:
4 years, 11 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the alternate notification UI for Mac UX preferred this one. BUG=571056, 580091 Committed: https://crrev.com/8c027c7cbe3ce94ef6853af0b065f30861471280 Cr-Commit-Position: refs/heads/master@{#370695}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/notifications/notification_ui_manager_mac.mm View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Miguel Garcia
4 years, 11 months ago (2016-01-21 13:42:25 UTC) #2
Peter Beverloo
owners stamp lgtm, please wait for Robert's review https://codereview.chromium.org/1618713003/diff/1/chrome/browser/notifications/notification_ui_manager_mac.mm File chrome/browser/notifications/notification_ui_manager_mac.mm (right): https://codereview.chromium.org/1618713003/diff/1/chrome/browser/notifications/notification_ui_manager_mac.mm#newcode127 chrome/browser/notifications/notification_ui_manager_mac.mm:127: } ...
4 years, 11 months ago (2016-01-21 13:45:14 UTC) #4
Robert Sesek
LGTM
4 years, 11 months ago (2016-01-21 15:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618713003/20001
4 years, 11 months ago (2016-01-21 15:17:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 15:22:09 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8c027c7cbe3ce94ef6853af0b065f30861471280 Cr-Commit-Position: refs/heads/master@{#370695}
4 years, 11 months ago (2016-01-21 15:23:22 UTC) #11
Miguel Garcia
4 years, 11 months ago (2016-01-25 15:15:27 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1618713003/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_ui_manager_mac.mm (right):

https://codereview.chromium.org/1618713003/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_ui_manager_mac.mm:127: }
On 2016/01/21 13:45:14, Peter Beverloo wrote:
> -1 space indentation

Done.

Powered by Google App Engine
This is Rietveld 408576698