Remove duplicate typedef

skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite common for functions to be declared as returning SkCanvas* but defined as returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org

Committed: https://crrev.com/ed673bebe493d773cd858a00bcc609db9bc93079
Cr-Commit-Position: refs/heads/master@{#372084}

[tomhudson, 2016-01-27 15:32:00]

Description was changed from

==========
Remove duplicate typedef

skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful.
It's quite common for functions to be declared as returning
SkCanvas* but defined as returning skia::PlatformCanvas*, so it's
also not future-proof.
==========

to

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
==========

[tomhudson, 2016-01-27 15:32:00]

tomhudson@google.com changed reviewers:
+ fmalita@chromium.org

[tomhudson, 2016-01-27 15:34:25]

tomhudson@google.com changed reviewers:
+ reed@chromium.org

[tomhudson, 2016-01-27 15:34:25]

Florin, here's the simpler of the two changes we discussed last Thursday.

Mike: I explicitly need you or Brian to sign off on changing the
components/printing/renderer/DEPS dependency from skia/ext/ to
third_party/skia/. We could just *add* third_party/skia/, but after this CL
printing won't depend on anything in skia/ext/, so at least for now I'm keeping
the list short.

[tomhudson, 2016-01-27 15:52:11]

Description was changed from

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
==========

to

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
==========

[f(malita), 2016-01-27 20:16:12]

lgtm

https://codereview.chromium.org/1618703006/diff/40001/ui/gfx/canvas_paint_mac.mm
File ui/gfx/canvas_paint_mac.mm (right):

https://codereview.chromium.org/1618703006/diff/40001/ui/gfx/canvas_paint_mac...
ui/gfx/canvas_paint_mac.mm:63: SkCanvas* canvas = sk_canvas();
Nit: this looks like a functional change, even though it isn't (sk_canvas() &
platform_canvas() point to the same thing, per our earlier conversation).

Let's leave the platform_canvas->sk_canvas switch for the CL which consolidates
the two.

[f(malita), 2016-01-27 20:16:21]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 20:18:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618703006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618703006/40001

[commit-bot: I haz the power, 2016-01-27 21:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 21:45:02]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-01-28 14:06:45]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-01-28 14:06:45]

lgtm

[tomhudson, 2016-01-28 14:07:02]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2016-01-28 14:08:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618703006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618703006/40001

[commit-bot: I haz the power, 2016-01-28 14:14:29]

Description was changed from

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
==========

to

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
==========

[commit-bot: I haz the power, 2016-01-28 14:14:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 14:15:30]

Description was changed from

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
==========

to

==========
skia::PlatformCanvas is an alias for SkCanvas; this is unhelpful. It's quite
common for functions to be declared as returning SkCanvas* but defined as
returning skia::PlatformCanvas*, so it's also not future-proof.

R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org

Committed: https://crrev.com/ed673bebe493d773cd858a00bcc609db9bc93079
Cr-Commit-Position: refs/heads/master@{#372084}
==========

[commit-bot: I haz the power, 2016-01-28 14:15:31]

Patchset 3 (id:??) landed as
https://crrev.com/ed673bebe493d773cd858a00bcc609db9bc93079
Cr-Commit-Position: refs/heads/master@{#372084}