Issue 1618693009: CPDFText_ParseOptions never change from default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1618693009: CPDFText_ParseOptions never change from default. (Closed)

Created:
4 years, 11 months ago by Tom Sepez

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang, Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

CPDFText_ParseOptions never change from default. m_bGetCharCodeOnly and m_bOutputHyphen are never re-assigned. m_bNormalizeObjs is assigned in a method that is never called. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c818b5fc6cca9a7e1a2851b30e8a34f652ab0ea9

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -137 lines)			Patch
M	core/include/fpdftext/fpdf_text.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	core/src/fpdftext/fpdf_text_int.cpp	View	23 chunks	+76 lines, -125 lines	0 comments	Download
M	core/src/fpdftext/text_int.h	View	2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Tom Sepez

4 years, 11 months ago (2016-01-22 23:53:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c818b5fc6cca9a7e1a2851b30e8a34f652ab0ea9 (presubmit successful).