Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1618693005: [Interpreter] Add ForOf support. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add ForOf support. Adds support for ForOf to the interpreter. BUG=v8:4685 LOG=N Committed: https://crrev.com/380f8c8f46232d6b71b46b177942fc37e67d062d Cr-Commit-Position: refs/heads/master@{#33470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -1 line) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +15 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +93 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +237 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +110 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1584343006 Patch 1

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618693005/1
4 years, 11 months ago (2016-01-22 11:55:59 UTC) #2
rmcilroy
Orion, PTAL, thanks.
4 years, 11 months ago (2016-01-22 11:56:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 12:32:19 UTC) #6
oth
lgtm.
4 years, 11 months ago (2016-01-22 13:06:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618693005/1
4 years, 11 months ago (2016-01-22 15:53:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 15:54:32 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 15:55:11 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/380f8c8f46232d6b71b46b177942fc37e67d062d
Cr-Commit-Position: refs/heads/master@{#33470}

Powered by Google App Engine
This is Rietveld 408576698