Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1618693004: Revert "Revert of [profiler] Implement POC Sampling Heap Profiler (patchset #12 id:220001 of https:… (Closed)

Created:
4 years, 11 months ago by ofrobots
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of [profiler] Implement POC Sampling Heap Profiler (patchset #12 id:220001 of https://codereview.chromium.org/1555553002/ )" This reverts commit 77df8659c2c114a59450dc201881f91412f200f3. BUG= Committed: https://crrev.com/f7304757aecca8185206259a8530d529ac18eef4 Cr-Commit-Position: refs/heads/master@{#33473}

Patch Set 1 #

Patch Set 2 : Add flag to suppress randomness from sampling heap profiler tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+785 lines, -50 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M include/v8-profiler.h View 2 chunks +127 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +55 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +1 line, -48 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/profiler/heap-profiler.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/profiler/heap-profiler.cc View 2 chunks +26 lines, -0 lines 0 comments Download
A src/profiler/sampling-heap-profiler.h View 1 chunk +135 lines, -0 lines 0 comments Download
A src/profiler/sampling-heap-profiler.cc View 1 1 chunk +253 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618693004/20001
4 years, 11 months ago (2016-01-22 05:35:44 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 11 months ago (2016-01-22 05:35:45 UTC) #4
Yang
On 2016/01/22 05:35:45, commit-bot: I haz the power wrote: > Dry run: No L-G-T-M from ...
4 years, 11 months ago (2016-01-22 15:03:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618693004/20001
4 years, 11 months ago (2016-01-22 15:30:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10063)
4 years, 11 months ago (2016-01-22 15:37:32 UTC) #11
Hannes Payer (out of office)
lgtm
4 years, 11 months ago (2016-01-22 15:39:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618693004/20001
4 years, 11 months ago (2016-01-22 16:35:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 16:36:45 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 16:37:08 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7304757aecca8185206259a8530d529ac18eef4
Cr-Commit-Position: refs/heads/master@{#33473}

Powered by Google App Engine
This is Rietveld 408576698