[Interpreter] Ensure context is popped when we break or continue

[Interpreter] Ensure context is popped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280, v8:4678
LOG=N

Committed: https://crrev.com/847ac580f15edf36aa2f2bf0735ac0013c912a19
Cr-Commit-Position: refs/heads/master@{#33464}

[rmcilroy, 2016-01-21 10:58:24]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 10:58:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618693002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618693002/20001

[rmcilroy, 2016-01-21 11:00:48]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, oth@chromium.org

[rmcilroy, 2016-01-21 11:00:49]

Michi / Orion, PTAL, thanks.

[commit-bot: I haz the power, 2016-01-21 11:19:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 11:19:25]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-01-21 12:10:05]

Description was changed from

==========
[Interpreter] Ensure context is poped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280,v8:4678
LOG=N
==========

to

==========
[Interpreter] Ensure context is popped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280,v8:4678
LOG=N
==========

[oth, 2016-01-21 12:53:22]

lgtm

[oth, 2016-01-21 12:53:23]

lgtm

[Michael Starzinger, 2016-01-21 13:25:20]

https://codereview.chromium.org/1618693002/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1618693002/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:185: if (current->ShouldExecute(command,
statement)) {
As discussed offline: How would you feel about going for the sub-optimal
solution of potential popping a context for every control scope first? That way
the implementation of the various control scopes stays simple while we hack on
them. We can certainly leave a TODO in that regard. Once we got them all done we
can revisit how to optimize away the redundant pops. WDYT?

[rmcilroy, 2016-01-22 11:46:08]

https://codereview.chromium.org/1618693002/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1618693002/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:185: if (current->ShouldExecute(command,
statement)) {
On 2016/01/21 13:25:20, Michael Starzinger wrote:
> As discussed offline: How would you feel about going for the sub-optimal
> solution of potential popping a context for every control scope first? That
way
> the implementation of the various control scopes stays simple while we hack on
> them. We can certainly leave a TODO in that regard. Once we got them all done
we
> can revisit how to optimize away the redundant pops. WDYT?

Done.

[Michael Starzinger, 2016-01-22 11:47:59]

LGTM. Thanks!

[rmcilroy, 2016-01-22 11:49:16]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 11:49:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618693002/60001

[commit-bot: I haz the power, 2016-01-22 12:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 12:17:48]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-01-22 12:40:39]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-01-22 12:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1618693002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-22 12:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1618693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1618693002/60001

[commit-bot: I haz the power, 2016-01-22 12:42:05]

Description was changed from

==========
[Interpreter] Ensure context is popped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280,v8:4678
LOG=N
==========

to

==========
[Interpreter] Ensure context is popped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280,v8:4678
LOG=N
==========

[commit-bot: I haz the power, 2016-01-22 12:42:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-22 12:42:54]

Description was changed from

==========
[Interpreter] Ensure context is popped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280,v8:4678
LOG=N
==========

to

==========
[Interpreter] Ensure context is popped when we break or continue

Break and continue operations need to pop the context chain to the
correct context before jumping to the target.

BUG=v8:4280,v8:4678
LOG=N

Committed: https://crrev.com/847ac580f15edf36aa2f2bf0735ac0013c912a19
Cr-Commit-Position: refs/heads/master@{#33464}
==========

[commit-bot: I haz the power, 2016-01-22 12:42:55]

Patchset 4 (id:??) landed as
https://crrev.com/847ac580f15edf36aa2f2bf0735ac0013c912a19
Cr-Commit-Position: refs/heads/master@{#33464}