Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1618653004: Delete WebRtcLocalAudioTrackAdapter::GetRenderer. (Closed)

Created:
4 years, 11 months ago by nisse-chromium (ooo August 14)
Modified:
4 years, 11 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete WebRtcLocalAudioTrackAdapter::GetRenderer. This method is unused and obsolete. It's presence in chromium (since it's declared using override) blocks its final removal in webrtc. Committed: https://crrev.com/f40a48aa79176f6ff16e50da450b0907edd03a57 Cr-Commit-Position: refs/heads/master@{#370957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-chromium (ooo August 14)
4 years, 11 months ago (2016-01-22 07:39:09 UTC) #2
perkj_chrome
lgtm lots of stupidities... Thanks
4 years, 11 months ago (2016-01-22 12:49:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618653004/1
4 years, 11 months ago (2016-01-22 12:50:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 13:56:58 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 13:57:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f40a48aa79176f6ff16e50da450b0907edd03a57
Cr-Commit-Position: refs/heads/master@{#370957}

Powered by Google App Engine
This is Rietveld 408576698