Refine StorageMonitor storage device getter

chrome/browser/storage_monitor/storage_monitor.h

Index: chrome/browser/storage_monitor/storage_monitor.h
diff --git a/chrome/browser/storage_monitor/storage_monitor.h b/chrome/browser/storage_monitor/storage_monitor.h
index 7eab0b7743b925d9b3fffa009623e946c32b496d..ccfe82a2c74710a57f1655a0ceec3d8b58d1c0dc 100644
--- a/chrome/browser/storage_monitor/storage_monitor.h
+++ b/chrome/browser/storage_monitor/storage_monitor.h
@@ -67,7 +67,7 @@ class StorageMonitor {
   // Initialize the storage monitor. The provided callback, if non-null,
   // will be called when initialization is complete. If initialization has
   // already completed, this callback will be invoked within the calling stack.
-  // Before the callback is run, calls to |GetAttachedStorage| and
+  // Before the callback is run, calls to |GetAttachedRemovableStorages| and
   // |GetStorageInfoForPath| may not return the correct results. In addition,
   // registered observers will not be notified on device attachment/detachment.
   // Should be invoked on the UI thread; callbacks will be run on the UI thread.
@@ -102,8 +102,13 @@ class StorageMonitor {
       media_transfer_protocol_manager() = 0;
 #endif
 
+  // Returns the meta information for all available storages on the system,

[wrong vandebo, 2013/05/29 15:16:16]

We probably don't want to introduce a second method here.  We should just update
the description, name, and callers of the existing method.  StorageInfo contains
enough information to tell you if it is removable or not.

[Greg Billock, 2013/05/29 17:58:19]

We've discussed making the method return all known storages, instead of just
removable ones, and I think that is something we want to do. We need to get them
at this point, anyway.

+  // including fixed and removable storage. It may return an empty vector
+  // if the storage metadata retrieval is not completed yet.
+  virtual std::vector<StorageInfo> GetAllAvailableStorages() const;
+
   // Returns information for attached removable storage.
-  std::vector<StorageInfo> GetAttachedStorage() const;
+  std::vector<StorageInfo> GetAttachedRemovableStorages() const;
 
   void AddObserver(RemovableStorageObserver* obs);
   void RemoveObserver(RemovableStorageObserver* obs);