Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 1618593002: linux_client_unittest_shlib: fix cleaning (Closed)

Created:
4 years, 11 months ago by vapier
Modified:
4 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

linux_client_unittest_shlib: fix cleaning The EXTRA_PROGRAMS knob does not automatically trigger clean up of targets listed in it. Use CLEANFILES so we make sure `make clean` will delete the linux_client_unittest_shlib lib. BUG=chromium:579384 TEST=`make check` passes R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/b7033b3aa14123841e741d98788cee1acd041af9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M Makefile.am View 2 chunks +5 lines, -1 line 0 comments Download
M Makefile.in View 9 chunks +30 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vapier
4 years, 11 months ago (2016-01-21 07:23:09 UTC) #2
vapier
4 years, 11 months ago (2016-01-25 20:35:07 UTC) #4
Mark Mentovai
Do you need to do anything do deal with .dwo files if the user asked ...
4 years, 11 months ago (2016-01-25 21:26:44 UTC) #5
vapier
`make clean` does not delete any .dwo files currently. i can post a new CL ...
4 years, 11 months ago (2016-01-25 21:44:25 UTC) #6
Mark Mentovai
LGTM If it’s not standard for autotools “make clean” to deal with that, I don’t ...
4 years, 11 months ago (2016-01-25 21:48:46 UTC) #7
vapier
4 years, 11 months ago (2016-01-25 21:53:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7033b3aa14123841e741d98788cee1acd041af9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698