Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 1618563002: Forward declare StyleVariableData in StyleRareInheritedData instead of including it (Closed)

Created:
4 years, 11 months ago by Timothy Loh
Modified:
4 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward declare StyleVariableData in StyleRareInheritedData instead of including it This patch replaces an include of StyleVariableData with a forward declaration in StyleRareInheritedData. This significantly reduces the number of files that need to recompile when touching files like CSSVariableData and CSSParserToken from ~900 to ~50. Committed: https://crrev.com/3aba64835a9b07093f88bde2ea33d822c748d208 Cr-Commit-Position: refs/heads/master@{#370639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
4 years, 11 months ago (2016-01-21 05:29:57 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 11 months ago (2016-01-21 05:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618563002/1
4 years, 11 months ago (2016-01-21 05:35:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 06:49:21 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:50:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3aba64835a9b07093f88bde2ea33d822c748d208
Cr-Commit-Position: refs/heads/master@{#370639}

Powered by Google App Engine
This is Rietveld 408576698