Enable polymorphic inlining of StringBase [] and StringBase codeUnitAt

runtime/vm/intermediate_language.h

Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index cfd4c560e347ad5fb632809c11097de978d6ee20..c51661aa6aa02739d42ace58a568c52ee246f7af 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -183,6 +183,8 @@ class Range;
 
 // A list of core functions that internally dispatch based on received id.
 #define POLYMORPHIC_TARGET_LIST(V)                                             \

[Florian Schneider, 2014/02/17 11:56:12]

dbc: For now it's ok, but it's kind of tedious to keep these different lists. I
hope once all recognized methods are supported with polymorphic inlining we can
get rid of this subset of RECOGNIZED_LIST.

[Cutch, 2014/02/18 17:00:30]

I'd like to see this removed too. We need to teach the polymorphic inliner how
to do polymorphic inlining of multiple receivers with the same target function
(see flow_graph_optimizer.cc:3624).

+  V(_StringBase, [], StringBaseCharAt, 585372763)                              \
+  V(_StringBase, codeUnitAt, StringBaseCodeUnitAt, 1958436584)                 \
   V(_TypedList, _getInt8, ByteArrayBaseGetInt8, 272598802)                     \
   V(_TypedList, _getUint8, ByteArrayBaseGetUint8, 831354841)                   \
   V(_TypedList, _getInt16, ByteArrayBaseGetInt16, 1832126257)                  \
@@ -3708,9 +3710,9 @@ class StringFromCharCodeInstr : public TemplateDefinition<1> {
  public:
   StringFromCharCodeInstr(Value* char_code, intptr_t cid) : cid_(cid) {
     ASSERT(char_code != NULL);
-    ASSERT(char_code->definition()->IsLoadIndexed() &&
-           (char_code->definition()->AsLoadIndexed()->class_id() ==
-            kOneByteStringCid));
+    ASSERT(char_code->definition()->IsLoadIndexed());
+    ASSERT(char_code->definition()->AsLoadIndexed()->class_id() ==
+           kOneByteStringCid);
     SetInputAt(0, char_code);
   }