Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1618523003: Merge of "Add metrics regarding concurrent audible tabs in Chromium." (Closed)

Created:
4 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Merge of "Add metrics regarding concurrent audible tabs in Chromium." These metrics are keeping track of: - whether there is another audible tab when a tab becomes audible; - the maximum number of concurrent audible tab in a session; - how long there are 2 or more audible tabs at the same time. It is also recording when a tab gain or loses audible status. BUG=578049 Review URL: https://codereview.chromium.org/1591453005 Cr-Commit-Position: refs/heads/master@{#370435} (cherry picked from commit 44e4ef42ba9104b06ae212042452dfc81d89032b) Committed: https://chromium.googlesource.com/chromium/src/+/1f83af1978b886e6dbe728bd793074c23293d55d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -28 lines) Patch
A content/browser/media/audible_metrics.h View 1 chunk +49 lines, -0 lines 0 comments Download
A content/browser/media/audible_metrics.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A content/browser/media/audible_metrics_unittest.cc View 1 chunk +397 lines, -0 lines 0 comments Download
M content/browser/media/audio_stream_monitor.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/media/audio_stream_monitor.cc View 4 chunks +15 lines, -1 line 0 comments Download
M content/browser/media/audio_stream_monitor_unittest.cc View 9 chunks +67 lines, -20 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +25 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
4 years, 11 months ago (2016-01-21 18:15:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f83af1978b886e6dbe728bd793074c23293d55d.

Powered by Google App Engine
This is Rietveld 408576698