base/metrics/sample_map.cc - Issue 1618423004: Fix overflow bug in histogram sample data structures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/sample_map.cc

Issue 1618423004: Fix overflow bug in histogram sample data structures (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Rename tests, remove redundant comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/sample_map.cc

diff --git a/base/metrics/sample_map.cc b/base/metrics/sample_map.cc

index a691243f340112fdcf6166c6a22777d516b9523e..e276b91643b6a4fa567b2e4f84eb09b94a92a38c 100644

--- a/base/metrics/sample_map.cc

+++ b/base/metrics/sample_map.cc

@@ -19,7 +19,7 @@ SampleMap::~SampleMap() {}

void SampleMap::Accumulate(Sample value, Count count) {

sample_counts_[value] += count;

- IncreaseSum(count * value);

+ IncreaseSum(static_cast<int64_t>(count) * value);

IncreaseRedundantCount(count);

}

« no previous file with comments | « base/metrics/histogram_unittest.cc ('k') | base/metrics/sample_map_unittest.cc » ('j') | no next file with comments »