chrome/android/java/res/xml/privacy_preferences.xml - Issue 1618413002: Change the CBD dialog on Android to a PreferenceFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/xml/privacy_preferences.xml

Issue 1618413002: Change the CBD dialog on Android to a PreferenceFragment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed button, fixed tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/xml/clear_browsing_data_dialog.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/xml/privacy_preferences.xml

diff --git a/chrome/android/java/res/xml/privacy_preferences.xml b/chrome/android/java/res/xml/privacy_preferences.xml

index ecea52fc57f76083b66ab98cfbf2aa652dd3f332..d1e5a1b51713bac46f24c9c4ad43b7e6ae735c45 100644

--- a/chrome/android/java/res/xml/privacy_preferences.xml

+++ b/chrome/android/java/res/xml/privacy_preferences.xml

@@ -67,7 +67,8 @@

android:key="physical_web"

android:title="@string/physical_web_pref_title"

android:fragment="org.chromium.chrome.browser.preferences.privacy.PhysicalWebPreferenceFragment" />

- <org.chromium.chrome.browser.preferences.ButtonPreference

+ <Preference

msramek 2016/01/28 18:43:48 I had a discussion with our UX designer today and

android:key="clear_browsing_data"

- android:title="@string/clear_browsing_data_title" />

+ android:title="@string/clear_browsing_data_title"

+ android:fragment="org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataDialogFragment" />

</PreferenceScreen>