src/heap/heap.cc - Issue 1618343002: [interpreter, debugger] abstraction for source position calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1618343002: [interpreter, debugger] abstraction for source position calculation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove bogus assertion Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index f6bf24652e0e82afed19c440026652121b191a71..a7629c064b7ed7d9cee52c3eafd791229a86dfe8 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -772,8 +772,7 @@ void Heap::PreprocessStackTraces() {

if (!maybe_code->IsCode()) break;

Code* code = Code::cast(maybe_code);

int offset = Smi::cast(elements->get(j + 3))->value();

- Address pc = code->address() + offset;

- int pos = code->SourcePosition(pc);

+ int pos = code->SourcePosition(offset);

elements->set(j + 2, Smi::FromInt(pos));

}

« no previous file with comments | « src/frames.cc ('k') | src/isolate.cc » ('j') | no next file with comments »